From: Oliver Freyermuth <o.freyerm...@googlemail.com> Date: Wed, 24 Jan 2018 02:21:55 +0100
> Am 23.01.2018 um 23:13 schrieb Francois Romieu: >> >> It helps. Can you try the snippet below ? > > It seems to fix the issue - I could not reproduce memory corruption > anymore neither on an Ubuntu 17.10.1 live system (with patched > kernel module) nor on my Gentoo system (4.14.12 with your patch > applied) across several reboots and module reloads! Thanks for helping test this out. > Sorry for my ignorance, but I'm curious - the R32 is there to avoid > reordering of the writes? The R32 make sure the write(s) beforehand have reached the chip, and indeed another thing it ensures is write ordering. > Many thanks for the quick help. I don't know the policies, but from > user point of view, this should be a good candidate for backporting > to stable kernels, since many systems in the wild should be affected > by this, and spurious memory corruption leading to e.g. broken > filesystems is rather nasty. Hopefully Francois can post a bonafide patch for me to apply with a full commit log message etc. I'm really surprised we were clearing those registers after programming properly, I wonder what that was all about. :-/ Thanks again for your testing and help.
