On 01/23/2018 05:48 AM, Alexei Starovoitov wrote:
> The test incorrectly doing
> mkdir /mnt/cgroup-test-work-dirtest-bpf-based-device-cgroup
> instead of
> mkdir /mnt/cgroup-test-work-dir/test-bpf-based-device-cgroup
> 
> somehow such mkdir succeeds and new directory appears:
> /mnt/cgroup-test-work-dir/cgroup-test-work-dirtest-bpf-based-device-cgroup
> 
> Later cleanup via nftw("/mnt/cgroup-test-work-dir", ...);
> doesn't walk this directory.
> "rmdir /mnt/cgroup-test-work-dir" succeeds, but bpf program and
> dangling cgroup stays in memory.
> That's a separate issue on a cgroup side.

Purely cgroup side with regards to internal cleanup (which then as a
side effect doesn't drop ref on the BPF prog)? Is a fix taken care of?

> For now fix the test.
> 
> Fixes: 37f1ba0909df ("selftests/bpf: add a test for device cgroup controller")
> Signed-off-by: Alexei Starovoitov <a...@kernel.org>

Applied to bpf-next, thanks Alexei!

Reply via email to