Hi Jiri, On Thu, Jan 18, 2018 at 2:13 AM, Jiri Benc <jb...@redhat.com> wrote: > Looks much better. > > On Wed, 17 Jan 2018 09:32:51 -0800, William Tu wrote: >> + OVS_ERSPAN_OPT_IDX, /* be32 index */ > > Why don't you convert this to u32 while passing to/from user space? > >> + [OVS_ERSPAN_OPT_IDX] = { .len = sizeof(u32) }, > > sizeof(__be32) but see above. > > Thanks, > > Jiri
Thanks. Your suggestion makes sense. In the beginning I just want to avoid another ntoh, hton conversion. Since the ERSPAN iproute2 also assume u32 to/from userspace, I will change it here to use u32. William