From: David Miller <da...@davemloft.net>
Date: Wed, 17 Jan 2018 14:55:35 -0500 (EST)
> From: Jiri Pirko <j...@resnulli.us>
> Date: Wed, 17 Jan 2018 11:46:44 +0100
>
>> Currently the filters added to qdiscs are independent. So for example if you
>> have 2 netdevices and you create ingress qdisc on both and you want to add
>> identical filter rules both, you need to add them twice. This patchset
>> makes this easier and mainly saves resources allowing to share all filters
>> within a qdisc - I call it a "filter block". Also this helps to save
>> resources when we do offload to hw for example to expensive TCAM.
>
> Series applied, thanks Jiri et al.
Jiri, I'm not going to revert because of this, but please give me a follow-up
patch which deals with this warning:
net/sched/cls_api.c: In function ‘tc_dump_tfilter’:
net/sched/cls_api.c:1362:8: warning: ‘parent’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
if (!tcf_chain_dump(chain, q, parent, skb, cb,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
index_start, &index))
~~~~~~~~~~~~~~~~~~~~
It's one of those:
u32 var;
if (condition) {
...
goto out;
} else {
var = whatever;
}
use(var);
out:
...
situations that GCC can't seem to see properly.
Thanks.
