On Tue, Jan 16, 2018 at 12:45:06PM +0100, Lorenzo Bianconi wrote: > > On Sun, Jan 14, 2018 at 03:50:53PM +0100, Lorenzo Bianconi wrote: > >> Do not rely on l2specific_len value provided by userspace but set sublayer > >> length according to l2specific_type. > >> Fix a harmless issue in the switch default case in > >> l2tp_nl_cmd_session_create(). > >> > >> Changes since v1: > >> - remove l2specific_len parameter > >> - add sanity check on l2specific_type provided by userspace > >> > > Thanks for working on this Lorenzo. > > > > Whatever the discussions on patches 1 and 3 lead to: > > > > Reviewed-by: Guillaume Nault <g.na...@alphalink.fr> > > Tested-by: Guillaume Nault <g.na...@alphalink.fr> > > I will send a v3 later today dropping the first patch (I will send a > single one removing the switch later) and including your suggestion > for default case in l2tp_get_l2specific_len(). > Thanks for reviewing the patch :) > Great! Feel free to keep my Reviewed-by: and Tested-by: tags.
Regards, Guillaume
