On Mon, Jan 15, 2018 at 10:12 PM, Jason Wang <jasow...@redhat.com> wrote: > > > On 2018年01月16日 14:07, Cong Wang wrote: >> >> On Mon, Jan 15, 2018 at 10:00 PM, Jason Wang <jasow...@redhat.com> wrote: >>> >>> I mean we can leave __tun_detach() as is, and just add the cleanup to >>> tun_detach_all(). This is because in both cases, we're sure skb array has >>> been initialized before. >>> >> Oh, I thought the same before sending v3, but I believe it is easier to >> understand 'if (tfile->tx_array.ring.queue)' than 'if (tun)', because >> tx_array >> only depends on itself rather tfile->tun in this way. > > > Maybe just add a comment to explain in __tun_detach(), it avoids memset() > anyway. >
But __tun_detach(true) is not a hot path, a memset() doesn't harm anything.
