Re: [PATCH v2 net-next 3/5] l2tp: remove l2specific_len dependency in l2tp_core

[Guillaume Nault]

On Sun, Jan 14, 2018 at 03:50:56PM +0100, Lorenzo Bianconi wrote:
> --- a/net/l2tp/l2tp_core.h
> +++ b/net/l2tp/l2tp_core.h
> @@ -302,6 +302,17 @@ static inline void l2tp_session_dec_refcount(struct 
> l2tp_session *session)
>               l2tp_session_free(session);
>  }
>  
> +static inline int l2tp_get_l2specific_len(struct l2tp_session *session)
> +{
> +     switch (session->l2specific_type) {
> +     case L2TP_L2SPECTYPE_NONE:
> +             return 0;
> +     case L2TP_L2SPECTYPE_DEFAULT:
> +     default:
> +             return 4;
> +     }
> +}
> 
The data path only compares ->l2specific_type to L2SPECTYPE_DEFAULT and
treats any other value as L2SPECTYPE_NONE. Therefore, we should keep
this logic here and return 0 for unknown types.