Hello! > Really? > > It is used with needlock=0 by DCCP ipv6, for example. This case seems > correct too. What about sk_receive_skb()? dn_queue_skb()? In fact, > there seems to be numerous uses still with needlock=0, all legitimate.
Well, not quite legitime. sk_receive_skb() has the same bug as tcp_v4_rcv(). Call in backlog processing of ipv6/dccp is occasionally forgotten duplicate of one done in sk_receive_skb(). Yes, those places really added a bit to desire to get rid of this misuse of bh_lock_sock(). :-) > Let us to fix bugs first, and then consider rewriting the locking. To be honest, I think switching to RCU is the simplest bug fix. At least, it does not require to search where bh_lock_sock() is taken dn_queue_skb(), if it is not forgotten at all. :-) Alexey - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
