On 01/10/2018 12:47 AM, Cong Wang wrote: > On Tue, Jan 9, 2018 at 2:30 PM, Nikolay Aleksandrov > <[email protected]> wrote: >> >> Just for reference - this is identical to the first part of: >> https://patchwork.ozlabs.org/patch/252891/ >> >> I knew this looked familiar. :-) >> > > Yeah, except bonding is not even involved. Unless I misread, > DaveM rejected it because of bond, which I never touch here. > > The refcnt is paired in vlan_vid_{add,del}, and the calls are > paired in register/unreigster and NETDEV_UP/NETDEV_DOWN > after this patch. >
You should read all of my replies to Dave, specifically the last one where I describe exactly a memory leak, and IIRC the rejection was not because of the bonding part but exactly because of this change - the removal of the vlan_id conditional. I'm not arguing about this patch now, I've said what I had to say back then, I just gave it as a reference in case there's still relevant information in there. Thanks, Nik
