On Mon, Jan 8, 2018 at 4:03 PM, Pravin Shelar <pshe...@ovn.org> wrote: > On Fri, Jan 5, 2018 at 2:29 PM, William Tu <u9012...@gmail.com> wrote: >> The patch adds support for configuring the erspan version II >> fields for openvswitch. >> > The patch looks good, But it could change userspace API for > OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS, how are we going to handle > compatibility? > Thanks. Yes, it will break the previous API, which uses OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS only to store 32-bit erspan index. Should I create another tunnel key attr? Something like: - OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS, /* be32 ERSPAN index. */ + OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTSV1, /* compatibility for erspan v1, be32 ERSPAN index. */ + OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTSV2, /* supporting both v1 and v2 using Nested OVS_ERSPAN_OPT_* */
Regards, William
