Hi Ard, On Thu, Jan 4, 2018 at 3:07 AM, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > Hi Jassi, > > On 1 January 2018 at 05:14, <jassisinghb...@gmail.com> wrote: >> From: Jassi Brar <jassisinghb...@gmail.com> >> >> This patch adds documentation for Device-Tree bindings for the >> Socionext NetSec Controller driver. >> >> Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org> >> Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> >> --- >> .../devicetree/bindings/net/socionext-netsec.txt | 53 >> ++++++++++++++++++++++ >> 1 file changed, 53 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/net/socionext-netsec.txt >> >> diff --git a/Documentation/devicetree/bindings/net/socionext-netsec.txt >> b/Documentation/devicetree/bindings/net/socionext-netsec.txt >> new file mode 100644 >> index 0000000..b70e35b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/socionext-netsec.txt >> @@ -0,0 +1,53 @@ >> +* Socionext NetSec Ethernet Controller IP >> + >> +Required properties: >> +- compatible: Should be "socionext,synquacer-netsec" >> +- reg: Address and length of the control register area, followed by the >> + address and length of the EEPROM holding the MAC address and >> + microengine firmware >> +- interrupts: Should contain ethernet controller interrupt >> +- clocks: phandle to the PHY reference clock >> +- clock-names: Should be "phy_ref_clk" > > If clock-names is mandatory now even when only a single clock is > specified, > I know. Usually I follow maintainer's opinion unless I see myself losing sleep doing that.
> you should add it to the example as well. > Done. Thanks > However, please > be aware that hardware has shipped now with DT images that specify a > only a single clock and no clock-names property: those will require a > firmware upgrade before they can use this version of the driver. > Ok, for now I have dared ignore clock-names in driver.... until we have to support again instance that take in more than one clock. Thanks.
