On Thu, Jan 04, 2018 at 12:36:26PM +0000, James Chapman wrote:
> On 04/01/18 10:25, Guillaume Nault wrote:
> >> diff --git a/net/l2tp/l2tp_debugfs.c b/net/l2tp/l2tp_debugfs.c
> >> index eb69411..2c30587 100644
> >> --- a/net/l2tp/l2tp_debugfs.c
> >> +++ b/net/l2tp/l2tp_debugfs.c
> >> @@ -180,8 +180,8 @@ static void l2tp_dfs_seq_session_show(struct seq_file
> >> *m, void *v)
> >> session->lns_mode ? "LNS" : "LAC",
> >> session->debug,
> >> jiffies_to_msecs(session->reorder_timeout));
> >> - seq_printf(m, " offset %hu l2specific %hu/%hu\n",
> >> - session->offset, session->l2specific_type,
> >> session->l2specific_len);
> >> + seq_printf(m, " offset 0 l2specific %hu/%hu\n",
> >> + session->l2specific_type, session->l2specific_len);
> >>
> > Can't we drop "offset" completely?
>
> That would change the debugfs file layout. If we remove it, we should
> also update the header line which is in the debugs output and is
> intended to indicate the layout of data.
>
Yes, of course we'd have to keep them in sync.
Anyway, I don't really mind whether we keep offset in debugfs output or
not.
