On Tue, Jan 02, 2018 at 05:22:42PM +0000, Russell King - ARM Linux wrote: > Hi, > > This series converts mvneta to use phylink, which is necessary to > support the SFP cages on SolidRun's Clearfog platform. This series just > converts mvneta without adding the DT parts - having discussed with > Andrew, we believe we're too close to the merge window to submit that > patch. > > I've split the "net: mvneta: convert to phylink" patch up to make it > easier to review, and in doing so, spotted some minor corner cases that > needed to be fixed along the way. > > This series depends on the previously merged phylink patches in netdev, > along with the recently reviewed 7 patch series "Resolve races in phy > accessors" without which, the race described in patch 5 of that series > is very evident when triggering a dummy hibernate cycle. > > This series also illustrates how to convert mvpp2 to phylink. > > mvneta is the only user of the fixed_phy_update_state() API, and this > becomes redundant with the conversion. > > It would be good to get this series not only reviewed, but also > independently tested to ensure that I haven't missed anything - I only > have the Clearfog platform to test on, and that doesn't support all the > different interface modes that mvneta supports. > > A particularly interesting side effect of this series is that DSA > switches no longer need the "CPU" port and DSA facing MAC ethernet > instance to be marked as a fixed link anymore with mvneta - we can use > 1000BaseX mode, and the DSA to CPU link will use the 802.3z negotiation > to determine the link properties without needing the link parameters to > be explicitly stated in DT - that is a subject of a future patch. > > drivers/net/ethernet/marvell/Kconfig | 2 +- > drivers/net/ethernet/marvell/mvneta.c | 687 > ++++++++++++++++++++-------------- > drivers/net/phy/fixed_phy.c | 31 -- > include/linux/phy_fixed.h | 9 - > 4 files changed, 405 insertions(+), 324 deletions(-)
Of course, this series is for net-next, not net... forgot to add that annotation, sorry. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up
