> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Neftin, Sasha > Sent: Wednesday, December 20, 2017 10:57 PM > To: Benjamin Poirier <bpoir...@suse.com>; Kirsher, Jeffrey T > <jeffrey.t.kirs...@intel.com> > Cc: Ben Hutchings <ben.hutchi...@codethink.co.uk>; Gabriel C > <nix.or....@gmail.com>; netdev@vger.kernel.org; Christian Hesse > <l...@eworm.de>; sta...@vger.kernel.org; linux-ker...@vger.kernel.org; > intel-wired-...@lists.osuosl.org > Subject: Re: [Intel-wired-lan] [PATCH] e1000e: Fix > e1000_check_for_copper_link_ich8lan return value. > > On 11/12/2017 9:26, Benjamin Poirier wrote: > > e1000e_check_for_copper_link() and > e1000_check_for_copper_link_ich8lan() > > are the two functions that may be assigned to mac.ops.check_for_link > when > > phy.media_type == e1000_media_type_copper. Commit 19110cfbb34d > ("e1000e: > > Separate signaling for link check/link up") changed the meaning of the > > return value of check_for_link for copper media but only adjusted the first > > function. This patch adjusts the second function likewise. > > > > Reported-by: Christian Hesse <l...@eworm.de> > > Reported-by: Gabriel C <nix.or....@gmail.com> > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=198047 > > Fixes: 19110cfbb34d ("e1000e: Separate signaling for link check/link up") > > Tested-by: Christian Hesse <l...@eworm.de> > > Signed-off-by: Benjamin Poirier <bpoir...@suse.com> > > --- > > drivers/net/ethernet/intel/e1000e/ich8lan.c | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > >
Tested-by: Aaron Brown <aaron.f.br...@intel.com> > Acked by sasha.nef...@intel.com > > _______________________________________________ > Intel-wired-lan mailing list > intel-wired-...@osuosl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
