> 1) tcp_ack() is already very expensive. > I'm not sure how what we should do with that comment. We need Some trigger to free TLS records. tcp_ack seemed like a reasonable Trigger.
> 2) Since you do not pass any state here, this looks very suspicious to > me. > The state we need is the acknowledged sequence and it located in the socket. https://github.com/Mellanox/tls-offload/blob/tls_device_v3/net/tls/tls_device.c#L157