On Mon, Dec 18, 2017 at 11:30 AM, David Miller <[email protected]> wrote:
> From: Tonghao Zhang <[email protected]>
> Date: Thu, 14 Dec 2017 05:51:58 -0800
>
>> In some case, we want to know how many sockets are in use in
>> different _net_ namespaces. It's a key resource metric.
>
> Useful or not, you're not exporting this value.
>
> All this patch series does is convert the existing export of the
> global tally to add up the per-net values.
>
> So if you're not exporting the per-net value on it's own in any way,
> this patch series isn't achieving the stated goal.
>
> I'm not applying this series, sorry.
This value is already exported via procfs:
sockstat_seq_show() -> socket_seq_show().
And the proc file itself should already be per-net:
static int sockstat_seq_open(struct inode *inode, struct file *file)
{
return single_open_net(inode, file, sockstat_seq_show);
}
This patch just makes that value to be per-net too.