Re: [PATCH iproute2 1/3] iplink: Improve index parameter handling

[Stephen Hemminger]

On Mon, 18 Dec 2017 20:54:06 +0200
Serhey Popovych <serhe.popov...@gmail.com> wrote:

> diff --git a/ip/iplink.c b/ip/iplink.c
> index 1e685cc..4f9c169 100644
> --- a/ip/iplink.c
> +++ b/ip/iplink.c
> @@ -586,8 +586,10 @@ int iplink_parse(int argc, char **argv, struct 
> iplink_req *req,
>                       *name = *argv;
>               } else if (strcmp(*argv, "index") == 0) {
>                       NEXT_ARG();
> +                     if (*index)
> +                             duparg("index", *argv);
>                       *index = atoi(*argv);
> -                     if (*index < 0)
> +                     if (*index <= 0)

Why not use strtoul instead of atoi?