> -----Original Message-----
> From: Michael Chan [mailto:michael.c...@broadcom.com]
> Sent: Thursday, December 14, 2017 2:16 AM
> To: Chopra, Manish <manish.cho...@cavium.com>
> Cc: da...@davemloft.net; netdev@vger.kernel.org;
> andrew.gospoda...@broadcom.com; Elior, Ariel <ariel.el...@cavium.com>;
> Dept-Eng Everest Linux L2 <dept-engeverestlinu...@cavium.com>
> Subject: Re: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.
>
> On Wed, Dec 13, 2017 at 1:08 AM, Chopra, Manish
> <manish.cho...@cavium.com> wrote:
> >
> > Hi Michael, There seems a behavioral change here. This driver support
> > two HW aggregation modes [LRO and GRO] With the changes, Interfaces
> come with HW GRO enabled and LRO disabled by default as opposed to earlier
> where interfaces used to come with LRO enabled.
>
> Right. Before, you had both NETIF_F_GRO and NETIF_F_LRO set and the code
> looked at NETIF_F_LRO first and turned on LRO.
>
> Now, we set NETIF_F_GRO and NETIF_F_GRO_HW by default. NETIF_F_LRO is
> turned off since NETIF_F_GRO_HW is on.
>
> If you want, I can change it back to the old default.
>
Michael, I checked it on again, I tried to set LRO in dev->features and
dev->hw_features.
Somehow, it gets disabled after register_netdevice(). Any idea why ? Although,
I am not running any Bridge/bonding devices.
Looks like, without this series also devices seems to have LRO disabled by
default.
Not sure why register_netdevice() disables LRO even driver populates this
feature prior to register_netdevice().
