On 12/14/17 11:39 AM, Alexander Aring wrote:
> diff --git a/net/sched/sch_cbs.c b/net/sched/sch_cbs.c
> index 8bf6e163d29c..6d09ffd2371e 100644
> --- a/net/sched/sch_cbs.c
> +++ b/net/sched/sch_cbs.c
> @@ -219,14 +219,17 @@ static void cbs_disable_offload(struct net_device *dev,
> }
>
> static int cbs_enable_offload(struct net_device *dev, struct cbs_sched_data
> *q,
> - const struct tc_cbs_qopt *opt)
> + const struct tc_cbs_qopt *opt,
> + struct netlink_ext_ack *extack)
> {
> const struct net_device_ops *ops = dev->netdev_ops;
> struct tc_cbs_qopt_offload cbs = { };
> int err;
>
> - if (!ops->ndo_setup_tc)
> + if (!ops->ndo_setup_tc) {
> + NL_SET_ERR_MSG(extack, "Specified device does support cbs
> offload");
does *not* support ... ?
