Re: [PATCH net] tcp: refresh tcp_mstamp from timers callbacks

[Soheil Hassas Yeganeh]

On Tue, Dec 12, 2017 at 9:26 PM, Neal Cardwell <ncardw...@google.com> wrote:
> On Tue, Dec 12, 2017 at 9:22 PM, Eric Dumazet <eric.duma...@gmail.com> wrote:
>> From: Eric Dumazet <eduma...@google.com>
>>
>> Only the retransmit timer currently refreshes tcp_mstamp
>>
>> We should do the same for delayed acks and keepalives.
>>
>> Even if RFC 7323 does not request it, this is consistent to what linux
>> did in the past, when TS values were based on jiffies.
>>
>> Fixes: 385e20706fac ("tcp: use tp->tcp_mstamp in output path")
>> Signed-off-by: Eric Dumazet <eduma...@google.com>
>> Cc: Soheil Hassas Yeganeh <soh...@google.com>
>> Cc: Mike Maloney <malo...@google.com>
>> Cc: Neal Cardwell <ncardw...@google.com>
>> ---
>
> Acked-by: Neal Cardwell <ncardw...@google.com>
>
> Thanks, Eric!
>
> neal

Acked-by: Soheil Hassas Yeganeh <soh...@google.com>

This is a very nice catch! Thank you Eric!