RE: [PATCH] dt-bindings: fec: Make the phy-reset-gpio polarity explicit

[Andy Duan]

From: Fabio Estevam <feste...@gmail.com> Sent: Friday, December 08, 2017 10:12 
PM
>The GPIO polarity passed to phy-reset-gpio is ignored by the FEC driver and it
>is assumed to be active low.
>
>It can be active high only when the 'phy-reset-active-high' property is 
>present.
>
>The current examples pass active high polarity and work fine, but in order to
>improve the documentation make it explicit what the real polarity is.
>
>Signed-off-by: Fabio Estevam <fabio.este...@nxp.com>

Since driver don't take care the flag, it doesn't matter what the value for the 
gpio polarity flag.
But the change look like explicit for user. 

Acked-by: Fugang Duan <fugang.d...@nxp.com>

>---
> Documentation/devicetree/bindings/net/fsl-fec.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt
>b/Documentation/devicetree/bindings/net/fsl-fec.txt
>index f0dc944..2d41fb9 100644
>--- a/Documentation/devicetree/bindings/net/fsl-fec.txt
>+++ b/Documentation/devicetree/bindings/net/fsl-fec.txt
>@@ -59,7 +59,7 @@ ethernet@83fec000 {
>       reg = <0x83fec000 0x4000>;
>       interrupts = <87>;
>       phy-mode = "mii";
>-      phy-reset-gpios = <&gpio2 14 0>; /* GPIO2_14 */
>+      phy-reset-gpios = <&gpio2 14 GPIO_ACTIVE_LOW>; /* GPIO2_14 */
>       local-mac-address = [00 04 9F 01 1B B9];
>       phy-supply = <&reg_fec_supply>;
> };
>@@ -71,7 +71,7 @@ ethernet@83fec000 {
>       reg = <0x83fec000 0x4000>;
>       interrupts = <87>;
>       phy-mode = "mii";
>-      phy-reset-gpios = <&gpio2 14 0>; /* GPIO2_14 */
>+      phy-reset-gpios = <&gpio2 14 GPIO_ACTIVE_LOW>; /* GPIO2_14 */
>       local-mac-address = [00 04 9F 01 1B B9];
>       phy-supply = <&reg_fec_supply>;
>       phy-handle = <&ethphy>;
>--
>2.7.4