From: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp> Date: Fri, 8 Dec 2017 11:14:56 +0900
> Initial discussion started about correct handling of this condition. > Later it was decided to remove this check altogether to make it > consistent. > > Removal of this check isn't fatal to this driver. ... > @@ -469,8 +469,6 @@ static int __init nsim_module_init(void) > int err; > > nsim_ddir = debugfs_create_dir(DRV_NAME, NULL); > - if (IS_ERR(nsim_ddir)) > - return PTR_ERR(nsim_ddir); > > err = bus_register(&nsim_bus); Please stop this madness. You cannot continue if this thing returns NULL. WHY? Because later if you pass NULL to debugfs_create_dir() in nsim_init() do you have any idea what it is going to do? It's going to put the netdevsim device files into the root! Please: 1) Handle the errors 2) Make them fatal, if DEBUGFS is enabled this should never fail except for memory allocation failures and we have bigger problems than successfully loading the netdevsim driver 3) Fix debugfs_create_dir() to have sane return value semantics so that people do not have to check both NULL and error pointers Thank you.
