On Fri, Dec 8, 2017 at 11:34 AM, Quentin Monnet <quentin.mon...@netronome.com> wrote: > 2017-12-07 18:39 UTC+0000 ~ Roman Gushchin <g...@fb.com> >> This patch adds basic cgroup bpf operations to bpftool: >> cgroup list, attach and detach commands.
[...] >> --- /dev/null >> +++ b/tools/bpf/bpftool/cgroup.c >> @@ -0,0 +1,305 @@ >> +/* >> + * Copyright (C) 2017 Facebook >> + * >> + * This program is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License >> + * as published by the Free Software Foundation; either version >> + * 2 of the License, or (at your option) any later version. >> + * >> + * >> + */ >> + Roman, Have you considered using the simpler and new SPDX ids instead? e.g.: // SPDX-License-Identifier: GPL-2.0+ // Copyright (C) 2017 Facebook // Author: Roman Gushchin <g...@fb.com> This would boost your code/comments ratio nicely IMHO. For reference please check Linus [1][2][3], Thomas [4] and Greg [5] comments on the topic of C++ style // comments! Jonathan also wrote a nice background article on the SPDXification topic at LWN [6] PS: and if you could spread the word at FB, that would we awesome! [1] https://lkml.org/lkml/2017/11/2/715 [2] https://lkml.org/lkml/2017/11/25/125 [3] https://lkml.org/lkml/2017/11/25/133 [4] https://lkml.org/lkml/2017/11/2/805 [5] https://lkml.org/lkml/2017/10/19/165 [6] https://lwn.net/Articles/739183/ -- Cordially Philippe Ombredanne
