From: David Ahern <dsah...@gmail.com> Date: Wed, 6 Dec 2017 20:09:12 -0800
> Commit 28033ae4e0f5 ("net: netlink: Update attr validation to require > exact length for some types") requires attributes using types NLA_U* and > NLA_S* to have an exact length. This change is exposing bugs in various > userspace commands that are sending attributes with an invalid length > (e.g., attribute has type NLA_U8 and userspace sends NLA_U32). While > the commands are clearly broken and need to be fixed, users are arguing > that the sudden change in enforcement is breaking older commands on > newer kernels for use cases that otherwise "worked". > > Relax the validation to print a warning mesage similar to what is done > for messages containing extra bytes after parsing. > > Fixes: 28033ae4e0f5 ("net: netlink: Update attr validation to require exact > length for some types") > Signed-off-by: David Ahern <dsah...@gmail.com> > Reviewed-by: Johannes Berg <johan...@sipsolutions.net> > --- > v2 > - updated the comment before nla_attr_len and removed the outdated > comment before use of nla_attr_len Applied and queued up for -stable, thanks David.