On 17-12-07 12:28 AM, David Ahern wrote:
- err = nla_parse_nested(tb, TCA_STAB_MAX, opt, stab_policy, NULL);
- if (err < 0)
+ err = nla_parse_nested(tb, TCA_STAB_MAX, opt, stab_policy, extack);
+ if (err < 0) {
+ NL_SET_ERR_MSG(extack, "Failed to parse stab netlink msg");
you don't want to set extack here; it should be set in nla_parse_nested
since it is passed as an arg.
Can you really have a generic message in nla_parse(_nested)? What
would it say?
Note: the bad attribute is saved in the bowels of nla_parsing.
-
stab = kmalloc(sizeof(*stab) + tsize * sizeof(u16), GFP_KERNEL);
- if (!stab)
+ if (!stab) {
+ NL_SET_ERR_MSG(extack, "Failed to allocate memory for stab
data");
ENOMEM does not need a text message. Which memory allocation failed is
not really relevant.
YMMV.
On the one hand it is useful to distinguish which allocation
in the code path failed(if there was a bug for example).
On the other hand you could argue an alloc failure is as dramatic
as the "sky is falling" - doesnt matter what part of the globe it is
falling at. If the cost of sending or not is the same why not include
the message?
cheers,
jamal
