From: Alexander Aring <ar...@mojatatu.com> Date: Wed, 6 Dec 2017 17:34:08 -0500
> Hi, > > On Wed, Dec 6, 2017 at 3:40 PM, David Miller <da...@davemloft.net> wrote: >> From: Alexander Aring <ar...@mojatatu.com> >> Date: Wed, 6 Dec 2017 11:08:39 -0500 >> >>> this patch series basically add support for extack in common qdisc handling. >>> Additional it adds extack pointer to common qdisc callback handling this >>> offers per qdisc implementation to setting the extack message for each >>> failure over netlink. >>> >>> The extack message will be set deeper in qdisc functions but going not >>> deeper as net core api. For qdisc module callback handling, the extack >>> will not be set. This will be part of per qdisc extack handling. >>> >>> I also want to prepare patches to handle extack per qdisc module... >>> so there will come a lot of more patches, just cut them down to make >>> it reviewable. >>> >>> There are some above 80-chars width warnings, which I ignore because >>> it looks more ugly otherwise. >>> >>> This patch-series based on patches by David Ahren which gave me some >>> hints how to deal with extack support. >>> >>> Cc: David Ahern <dsah...@gmail.com> >> >> Only add the plumbing when you have actual extack messages you are >> adding as an example use case. >> > > I did not understand. I have a lot of patches which make use of these > changes. Do you want me to submit me these in one shot (patch-series)? > I was hoping to making it in smaller patch-series for easier review. Submit one plumbing patch alongside the changes that actually add messages in those code paths. This patch series did plumbing in many spots, one patch at a time, but added no users except in the initial path. That's what I don't like.
