On Mon, Dec 04, 2017 at 05:27:24PM -0800, Song Liu wrote:
> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> index 362493a..0f39b31 100644
> --- a/include/uapi/linux/perf_event.h
> +++ b/include/uapi/linux/perf_event.h
> @@ -291,6 +291,16 @@ enum perf_event_read_format {
> PERF_FORMAT_MAX = 1U << 4, /* non-ABI */
> };
>
> +/*
> + * Flags in config, used by dynamic PMU kprobe and uprobe
> + *
> + * PERF_PROBE_CONFIG_IS_RETPROBE if set, create kretprobe/uretprobe
> + * if not set, create kprobe/uprobe
> + */
> +enum perf_probe_config {
> + PERF_PROBE_CONFIG_IS_RETPROBE = 1U << 0, /* [k,u]retprobe */
> +};
This should not be in uapi; pmu's can describe their config format in
sysfs.
PMU_FORMAT_ATTR(retprobe, "config:0");
static struct attribute *kprobe_attr[] = {
&format_attr_retprobe,
NULL,
};
static struct attribute_group kprobe_format_group = {
.name = "format",
.attrs = kprobe_attrs,
};
static const struct attribute_group *kprobe_attr_groups[] = {
&kprobe_format_group,
NULL,
};
struct pmu perf_kprobe {
...
.attr_groups = kprobe_attr_groups,
};
Other than that, this series looks good to me. Thanks!
