Re: [PATCH 07/10] net: ethernet: smsc: Handle return value of platform_get_irq

[Sergei Shtylyov]

On 12/02/2017 10:26 PM, Arvind Yadav wrote:

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
  drivers/net/ethernet/smsc/smc911x.c | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/drivers/net/ethernet/smsc/smc911x.c 
b/drivers/net/ethernet/smsc/smc911x.c
index 0515744..a1cf18c 100644
--- a/drivers/net/ethernet/smsc/smc911x.c
+++ b/drivers/net/ethernet/smsc/smc911x.c
@@ -2088,6 +2088,11 @@ static int smc911x_drv_probe(struct platform_device 
*pdev)

ndev->dma = (unsigned char)-1;

        ndev->irq = platform_get_irq(pdev, 0);
+       if (ndev->irq <= 0) {
+               ret = ndev->irq ? ndev->irq : -ENODEV;

   Same comments as the next patch...

+               goto release_both;
+       }
+
        lp = netdev_priv(ndev);
        lp->netdev = ndev;
  #ifdef SMC_DYNAMIC_BUS_CONFIG

MBR, Sergei