On Fri, Dec 01, 2017 at 12:19:52PM -0800, Jakub Kicinski wrote:
> On Fri, 1 Dec 2017 14:46:34 +0100, Phil Sutter wrote:
> > On Thu, Nov 30, 2017 at 05:35:40PM -0800, Jakub Kicinski wrote:
> > > netdevsim driver seems like a better place for fake SR-IOV
> > > functionality.  Remove the code previously added to dummy.
> > > 
> > > Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com>
> > > Reviewed-by: Quentin Monnet <quentin.mon...@netronome.com>  
> > 
> > Acked-by: Phil Sutter <p...@nwl.cc>
> 
> Thanks!
> 
> Did you have an opportunity to run your tests against this?  I didn't
> find anything that uses dummy's SR-IOV in selftests.

In fact, at Red Hat nobody uses dummy for iproute SR-IOV testing yet
(which was the motivation for it in the first place). Hence why I didn't
see a problem with moving it from dummy over to something else.

Hopefully upstream iproute will at some point contain a testsuite which
makes use of this, but sadly that's still wishful thinking. :(

Cheers, Phil

Reply via email to