On Wed, 23 Aug 2006 09:05:30 +0200, Johannes Berg wrote: > On Tue, 2006-08-22 at 21:00 +0200, Jiri Benc wrote: > > When you're touching this, could you #ifdef out wpa_test when > > CONFIG_HOSTAPD_WPA_TESTING is not defined? This could be a part of this > > patch. > > I thought about it but deemed it too ugly. And wouldn't the compiler > optimize it away anyway? Thing is, it's used in tests, and having > #ifdefs within if (...) tests is hugely ugly.
#ifdefs within if tests are ugly, I agree. I thought about restructuring these ifs. Okay, we will go with your patch and address this later. Thanks, Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
