On Tue, 2006-08-22 at 10:34 -0700, David Kimdon wrote:
> This ioctl is used when radar is delected on a channel. Data frames must stop
> but management frames must be allowed to continue for some time to communicate
> the channel switch to stations.
Which does lead to the question: How are you detecting radar in
userspace in the first place??
> + if (unlikely(local->stop_data_frame_tx)) {
> + struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)
> skb->data;
> + u16 fc = le16_to_cpu(hdr->frame_control);
> + if ((fc & IEEE80211_FCTL_FTYPE) == IEEE80211_FTYPE_DATA) {
> + dev_kfree_skb(skb);
> + return 0;
> + }
> + }
Should that really drop dataframes dead on the floor? And wouldn't it
make sense stop the networking layer from injecting more data into the
stack when stop_data_frame_tx is enabled?
> +static int ieee80211_ioctl_set_stop_data_frame_tx(struct net_device *dev,
> + int val)
> +{
> + struct ieee80211_local *local = dev->ieee80211_ptr;
> + local->stop_data_frame_tx = val;
> + return 0;
> +}
Again, whitespace damaged. Yes, I know it's hard to code in there with
any smart editor that thinks it knows what to do based on the
surroundings because those may also contain whitespace...
> + ret = ieee80211_ioctl_set_stop_data_frame_tx(dev, value);
Ditto.
johannes
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
