On Tue, 2006-08-22 at 10:33 -0700, David Kimdon wrote:
> + if (param->u.if_info.type == HOSTAP_IF_WDS) {
> + type = IEEE80211_IF_TYPE_WDS;
> + } else if (param->u.if_info.type == HOSTAP_IF_VLAN) {
> + type = IEEE80211_IF_TYPE_VLAN;
> + } else if (param->u.if_info.type == HOSTAP_IF_BSS) {
> + type = IEEE80211_IF_TYPE_AP;
> + } else if (param->u.if_info.type == HOSTAP_IF_STA) {
> + type = IEEE80211_IF_TYPE_STA;
> + } else {
> + return -EINVAL;
> }
IMHO that'd look better as a switch(). Or maybe even a small static
array to map them and just some bounds checking code?
Also, spaces instead of tab on the last added line.
johannes
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
