On Tue, 2006-08-22 at 20:36 +0200, Jiri Benc wrote: > On Mon, 21 Aug 2006 09:41:14 +0200, Johannes Berg wrote: > > I think this is not correct if a STA is removed for which packets > > are buffered, but if it is still wrong then that case was never > > correct to start with if the hw has a set_tim callback. > > You're right, good catch.
:) > > + /* 251 = max size of tim bitmap in beacon */ > > + for (i = 0; i < 251; i++) { > > Please, use a constant here. Yeah, good point. > > + u8 tim[sizeof(unsigned long)*BITS_TO_LONGS(MAX_AID_TABLE_SIZE+1)]; > > Hm, adding spaces here would extend the line above 80 characters... But > this way it doesn't look good. What to do here? I'd prefer leaving the > line a little over 80 chars in this case. What do you think? Heh, didn't even really think about that. I can throw in a few spaces. > > @@ -424,13 +424,6 @@ void sta_info_remove_aid_ptr(struct sta_ > > sdata = IEEE80211_DEV_TO_SUB_IF(sta->dev); > > if (sta->aid <= 0 || !sdata->bss) > > return; > > - > > - sdata->bss->sta_aid[sta->aid - 1] = NULL; > > - if (sta->aid == sdata->bss->max_aid) { > > - while (sdata->bss->max_aid > 0 && > > - !sdata->bss->sta_aid[sdata->bss->max_aid - 1]) > > - sdata->bss->max_aid--; > > - } > > } > > Why are you not calling bss_tim_clear here? Am I missing something? Dunno. I probably just looked at the code and thought 'oh, all this does is updated max_aid, let me get rid of it' :) > Also, adding hw->set_tim call here should fix the problem you described > at the beginning of the mail. Yeah, I guess so. johannes - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html