On Wed, Nov 29, 2017 at 11:37 PM, Andrew Lunn <and...@lunn.ch> wrote: > On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote: >> On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: >> > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: >> > > The driver expect "allwinner,leds-active-low" to be in PHY node, but >> > > the binding doc expect it to be in MAC node. >> > > >> > > Since all board DT use it also in MAC node, the driver need to search >> > > allwinner,leds-active-low in MAC node. >> > >> > Hi Corentin >> > >> > I'm having trouble working out how this worked before. This is code >> > you moved around, when adding external/internal MDIOs. But the very >> > first version of this driver code used priv->plat->phy_node. Did that >> > somehow point to the MAC node when the internal PHY is used? Or has it >> > been broken all the time? >> > >> >> Hello >> > >> Since this feature control only when the activity LED need to blink, >> nobody see that it was broken. > > Hi Corentin > > So it never worked? > > If it never worked, moving the DT properties into the PHY node, where > they belong, won't introduce a regression :-)
It worked at one point. During some previous iteration, they lit up as they were supposed to. ChenYu
