On Tue, Nov 28, 2017 at 9:50 AM, Cong Wang <xiyou.wangc...@gmail.com> wrote:
> On Tue, Nov 28, 2017 at 5:28 AM, Paolo Abeni <pab...@redhat.com> wrote:
>> While converting sch_sfq to use timer_setup(), the commit cdeabbb88134
>> ("net: sched: Convert timers to use timer_setup()") forgot to
>> initialize the 'sch' field. As a result, the timer callback tries to
>> dereference a NULL pointer, and the kernel does oops.
>>
>> Fix it initializing such field at qdisc creation time.
>>
>> Fixes: cdeabbb88134 ("net: sched: Convert timers to use timer_setup()")
>> Signed-off-by: Paolo Abeni <pab...@redhat.com>
>
> Acked-by: Cong Wang <xiyou.wangc...@gmail.com>Thanks for the catch! Yup, this was a goof on my end (all other timers correctly initialize that value, but the one in sfq_init() got missed). Thanks! Acked-by: Kees Cook <keesc...@chromium.org> -Kees -- Kees Cook Pixel Security
