> Hi Andrew,
>
> Bhaskar is working on enabling a PFE [1] MAC connected to an Aquantia AQR107
> PHY [2] on a LS1012AQDS board. Initially I've indicated 2500Base-X too, but it
> seems the HW actually works in SGMII mode. The QDS boards are lower volume,
> higher spec boards than the RDBs [3], they exercise most of the HW
> capabilities.
The webpage for the AQR107 lists 2500Base-X, so i assume the issue is
with the MAC? Ideally you want to use 2500Base-X, since this is wider
known.
Anyway, you seem to have a legitimate need for it.
However, i would prefer a different name. The convention is to put the
number first. So PHY_INTERFACE_MODE_2500SGMII.
Andrew