On Mon, 21 Aug 2006, Johannes Berg wrote:
> Please review carefully, the task was so boring that I might have made
> stupid mistakes.
> ---
> This huge patch changes d80211 to treat pointers as "extended booleans",
> using "if (!ptr)" and "if (ptr)" instead of comparisons with NULL.
>
> Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
>
> --- wireless-dev.orig/net/d80211/ieee80211_scan.c 2006-08-20
> 14:56:09.738192788 +0200
> +++ wireless-dev/net/d80211/ieee80211_scan.c 2006-08-20 14:56:17.398192788
> +0200
[...]
> @@ -1105,8 +1105,8 @@ __ieee80211_tx_prepare(struct ieee80211_
> tx->fragmented = local->fragmentation_threshold <
> IEEE80211_MAX_FRAG_THRESHOLD && tx->u.tx.unicast &&
> skb->len + 4 /* FCS */ > local->fragmentation_threshold &&
> - (local->hw->set_frag_threshold == NULL);
> - if (tx->sta == NULL)
> + (!local->hw->set_frag_threshold);
> + if (!tx->sta)
> control->clear_dst_mask = 1;
> else if (tx->sta->clear_dst_mask) {
> control->clear_dst_mask = 1;
[...]
Just a minor nit. I don't believe the "()" on the first new line
are needed.
-Bill
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
