On 11/14/17 9:18 AM, Jiri Pirko wrote:
> @@ -192,6 +194,8 @@ struct devlink_dpipe_table {
> const char *name;
> bool counters_enabled;
> bool counter_control_extern;
> + u64 resource_id;
> + bool resource_valid;
from a space perspective, please reverse the order
> struct devlink_dpipe_table_ops *table_ops;
> struct rcu_head rcu;
> };
> @@ -387,6 +391,8 @@ void devlink_resources_unregister(struct devlink *devlink,
> int devlink_resource_size_get(struct devlink *devlink,
> u64 resource_id,
> u64 *p_resource_size);
> +int devlink_dpipe_table_resource_set(struct devlink *devlink,
> + const char *table_name, u64 resource_id);
>
> #else
>
> @@ -550,6 +556,13 @@ devlink_resource_size_get(struct devlink *devlink, u64
> resource_id,
> return -EINVAL;
> }
>
> +static inline int
> +devlink_dpipe_table_resource_set(struct devlink *devlink,
> + const char *table_name, u64 resource_id)
> +{
> + return -EINVAL;
It's compiled out so -EOPNOTSUPP seems more appropriate.
