On 11/09/2017 02:26 PM, Florian Fainelli wrote:
> dev->cpu_port is the driver local information that should only be used
> to look up register offsets for a particular port, when they differ
> (e.g: IMP port override), but it should certainly not be used in place
> of the DSA configured CPU port.
>
> Since the DSA switch layer calls port_vlan_{add,del}() on the CPU port
> as well, we can remove the specific setting of the CPU port within
> port_vlan_{add,del}.
>
> Fixes: ff39c2d68679 ("net: dsa: b53: Add bridge support")
> Fixes: 967dd82ffc52 ("net: dsa: b53: Add support for Broadcom RoboSwitch")
> Signed-off-by: Florian Fainelli <f.faine...@gmail.com>
> ---
> drivers/net/dsa/b53/b53_common.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/dsa/b53/b53_common.c
> b/drivers/net/dsa/b53/b53_common.c
> index a7ca62ba27b7..5e48e98b6187 100644
> --- a/drivers/net/dsa/b53/b53_common.c
> +++ b/drivers/net/dsa/b53/b53_common.c
> @@ -325,7 +325,6 @@ static void b53_get_vlan_entry(struct b53_device *dev,
> u16 vid,
>
> static void b53_set_forwarding(struct b53_device *dev, int enable)
> {
> - struct dsa_switch *ds = dev->ds;
> u8 mgmt;
This hunk would break bisectability, let me respin something quickly
with that corrected.
--
Florian
