On Fri, 03 Nov 2017 01:54:01 -0700
Amritha Nambiar <[email protected]> wrote:
> + tc = strtoul(*argv, &end, 0);
> + if (*end) {
> + fprintf(stderr, "Illegal TC index\n");
> + return -1;
> + }
I will apply this, looks fine.
While looking at the flower parsing I noticed that the code
should have been using the function invarg() in utils rather
than calling fprintf(stderr,...). This is for a couple of reasons
the first is that its good to print the offending argument as
well as the reason, and the other one is that if a bad argument
is given then exit should be called rather than returning -1. If -1
is returned and batch mode is used, the batch continues. For the case
of bogus arguments it is better to die right away.
