On 01/11/17 - 18:00:10, Eric Dumazet wrote: > On Wed, 2017-11-01 at 17:10 -0700, Christoph Paasch wrote: > > > Yes, that looks good to me. Thanks! > > > > But we still need to clean up the skb in tcp_v4_send_reset and > > tcp_v4_send_ack, as the fields (e.g., tcp_skb_cb->seq) have been set when > > coming from tcp_v4_rcv. > > You might be confused : ip_send_unicast_reply() does not send back the > incoming skb. > > A fresh skb is allocated, then appended/sent. > > And commit 24a2d43d8886f5a29c did the changes to provide to > __ip_options_echo() the proper IPCB header location.
Yes, sorry I misunderstood ip_send_unicast_reply(). Didn't see the allocation of the new skb. Christoph
