From: Jiong Wang <jiong.w...@netronome.com>

The current ALU_OP_NEG is Op encoding 0x4 for NPF ALU instruction. It is
actually performing "~B" operation which is bitwise NOT.

The using naming ALU_OP_NEG is misleading as NEG is -B which is not the
same as ~B.

Signed-off-by: Jiong Wang <jiong.w...@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com>
---
 drivers/net/ethernet/netronome/nfp/bpf/jit.c | 2 +-
 drivers/net/ethernet/netronome/nfp/nfp_asm.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/netronome/nfp/bpf/jit.c 
b/drivers/net/ethernet/netronome/nfp/bpf/jit.c
index e7eeb7a07f81..369173100fcf 100644
--- a/drivers/net/ethernet/netronome/nfp/bpf/jit.c
+++ b/drivers/net/ethernet/netronome/nfp/bpf/jit.c
@@ -944,7 +944,7 @@ wrp_alu_imm(struct nfp_prog *nfp_prog, u8 dst, enum alu_op 
alu_op, u32 imm)
        if (alu_op == ALU_OP_XOR) {
                if (!~imm)
                        emit_alu(nfp_prog, reg_both(dst), reg_none(),
-                                ALU_OP_NEG, reg_b(dst));
+                                ALU_OP_NOT, reg_b(dst));
                if (!imm || !~imm)
                        return;
        }
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_asm.h 
b/drivers/net/ethernet/netronome/nfp/nfp_asm.h
index f4d1df3a1925..74d0c11ab2f9 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_asm.h
+++ b/drivers/net/ethernet/netronome/nfp/nfp_asm.h
@@ -174,7 +174,7 @@ enum shf_sc {
 enum alu_op {
        ALU_OP_NONE     = 0x00,
        ALU_OP_ADD      = 0x01,
-       ALU_OP_NEG      = 0x04,
+       ALU_OP_NOT      = 0x04,
        ALU_OP_AND      = 0x08,
        ALU_OP_SUB_C    = 0x0d,
        ALU_OP_ADD_C    = 0x11,
-- 
2.14.1

Reply via email to