On Tue, 31 Oct 2017 17:55:06 +0100
Stephen Hemminger <step...@networkplumber.org> wrote:

> On Sun, 29 Oct 2017 21:22:34 +0100
> Stefano Brivio <sbri...@redhat.com> wrote:
> 
> > +   addrp_width -= netid_width + 1 * !!netid_width;
> > +   addrp_width -= state_width + 1 * !!state_width;  
> 
> Doing !! here is being too bit tricky for code that is not performance 
> sensitive.
> Just use an if statement or ? :

Sure.

> > @@ -4373,6 +4374,8 @@ int main(int argc, char *argv[])
> >                     netid_width++;
> >             else if (state_width)
> >                     state_width++;
> > +           else
> > +                   odd_width_pad=" ";  
> 
> Missing whitespace.

Oops. Thanks. I'll fix both issues in v2.

-- 
Stefano

Reply via email to