From: Yi Yang <yi.y.y...@intel.com> Date: Thu, 26 Oct 2017 15:45:16 +0800
> OVS master and 2.8 branch has merged NSH userspace > patch series, this patch is to enable NSH support > in kernel data path in order that OVS can support > NSH in compat mode by porting this. > > Signed-off-by: Yi Yang <yi.y.y...@intel.com> One small request for function naming: > diff --git a/include/net/nsh.h b/include/net/nsh.h > index a1eaea2..7dcf377 100644 > --- a/include/net/nsh.h > +++ b/include/net/nsh.h > @@ -304,4 +304,7 @@ static inline void nsh_set_flags_ttl_len(struct nshhdr > *nsh, u8 flags, > NSH_FLAGS_MASK | NSH_TTL_MASK | NSH_LEN_MASK); > } > > +int skb_push_nsh(struct sk_buff *skb, const struct nshhdr *pushed_nh); > +int skb_pop_nsh(struct sk_buff *skb); > + > #endif /* __NET_NSH_H */ All functions named "skb_*" should be core SKB handling functions found and implemented in include/linux/skbuff.h and net/core/skbuff.c Protocol specific helpers like this should be named "$PROTOCOL_NAME_*" so please renamed these something like "nsh_header_push()" and "nsh_header_pop()". Thank you.
