On Fri, Oct 27, 2017 at 1:49 PM, Manish Kurup <kurup.man...@gmail.com> wrote: > static inline u32 tcf_vlan_action(const struct tc_action *a) > { > - return to_vlan(a)->tcfv_action; > + u32 tcfv_action; > + > + rcu_read_lock(); > + tcfv_action = rcu_dereference(to_vlan(a)->vlan_p)->tcfv_action; > + rcu_read_unlock(); > + > + return tcfv_action; > }
It seems we need rcu_read_lock_bh() rather than just rcu_read_lock()? If so, same for other tcf_vlan_*() helpers.