Tue, Oct 24, 2017 at 10:12:34PM CEST, steven.l...@broadcom.com wrote: >Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config >parameter. Value is permanent, so becomes the new default >value for this device. > > 0 = Disable SR-IOV > 1 = Enable SR-IOV > >Signed-off-by: Steve Lin <steven.l...@broadcom.com> >Acked-by: Andy Gospodarek <go...@broadcom.com> >--- > include/uapi/linux/devlink.h | 8 +++++++- > net/core/devlink.c | 1 + > 2 files changed, 8 insertions(+), 1 deletion(-) > >diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h >index 28ea961..ed520e7 100644 >--- a/include/uapi/linux/devlink.h >+++ b/include/uapi/linux/devlink.h >@@ -256,8 +256,14 @@ enum devlink_dpipe_header_id { > DEVLINK_DPIPE_HEADER_IPV6, > }; > >-/* Permanent config parameters */ >+/* Permanent config parameters: >+ * DEVLINK_PERM_CONFIG_SRIOV_ENABLED: >+ * 0 = disable SR-IOV >+ * 1 = enable SR-IOV
Enum please. Also, I would like to see more detailed description, including description how exactly the driver is expected to behave. Current description is still quite vague. >+ */ > enum devlink_perm_config_param { >+ DEVLINK_PERM_CONFIG_SRIOV_ENABLED, >+ > __DEVLINK_PERM_CONFIG_MAX, > DEVLINK_PERM_CONFIG_MAX = __DEVLINK_PERM_CONFIG_MAX - 1 > }; >diff --git a/net/core/devlink.c b/net/core/devlink.c >index 4deb4da..58ba715 100644 >--- a/net/core/devlink.c >+++ b/net/core/devlink.c >@@ -1569,6 +1569,7 @@ static int devlink_nl_cmd_eswitch_set_doit(struct >sk_buff *skb, > static const struct nla_policy devlink_nl_policy[DEVLINK_ATTR_MAX + 1]; > > static const u8 devlink_perm_cfg_param_types[DEVLINK_PERM_CONFIG_MAX + 1] = { >+ [DEVLINK_PERM_CONFIG_SRIOV_ENABLED] = NLA_U8, > }; > > static int devlink_nl_single_param_get(struct sk_buff *msg, >-- >2.7.4 >