Hi David,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 
master
head:   48acc9e847ef335f7d3b62926825397c6bf4eab2
commit: 386fd5da401dc6c4b0ab6a54d333609876b699fe [299/314] tcp: Check 
daddr_cache before use in tracepoint
config: x86_64-kexec (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout 386fd5da401dc6c4b0ab6a54d333609876b699fe
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from include/trace/define_trace.h:95:0,
                    from include/trace/events/tcp.h:68,
                    from net/core/net-traces.c:34:
   include/trace/events/tcp.h: In function 
'trace_event_raw_event_tcp_retransmit_skb':
>> include/net/sock.h:348:36: error: 'struct sock_common' has no member named 
>> 'skc_v6_rcv_saddr'; did you mean 'skc_rcv_saddr'?
    #define sk_v6_rcv_saddr __sk_common.skc_v6_rcv_saddr
                                       ^
   include/trace/trace_events.h:718:4: note: in definition of macro 
'DECLARE_EVENT_CLASS'
     { assign; }       \
       ^~~~~~
   include/trace/trace_events.h:77:9: note: in expansion of macro 'PARAMS'
            PARAMS(assign),         \
            ^~~~~~
   include/trace/events/tcp.h:12:1: note: in expansion of macro 'TRACE_EVENT'
    TRACE_EVENT(tcp_retransmit_skb,
    ^~~~~~~~~~~
   include/trace/events/tcp.h:29:2: note: in expansion of macro 'TP_fast_assign'
     TP_fast_assign(
     ^~~~~~~~~~~~~~
   include/trace/events/tcp.h:49:16: note: in expansion of macro 
'sk_v6_rcv_saddr'
       *pin6 = sk->sk_v6_rcv_saddr;
                   ^~~~~~~~~~~~~~~
>> include/net/sock.h:347:33: error: 'struct sock_common' has no member named 
>> 'skc_v6_daddr'; did you mean 'skc_daddr'?
    #define sk_v6_daddr  __sk_common.skc_v6_daddr
                                    ^
   include/trace/trace_events.h:718:4: note: in definition of macro 
'DECLARE_EVENT_CLASS'
     { assign; }       \
       ^~~~~~
   include/trace/trace_events.h:77:9: note: in expansion of macro 'PARAMS'
            PARAMS(assign),         \
            ^~~~~~
   include/trace/events/tcp.h:12:1: note: in expansion of macro 'TRACE_EVENT'
    TRACE_EVENT(tcp_retransmit_skb,
    ^~~~~~~~~~~
   include/trace/events/tcp.h:29:2: note: in expansion of macro 'TP_fast_assign'
     TP_fast_assign(
     ^~~~~~~~~~~~~~
   include/trace/events/tcp.h:51:16: note: in expansion of macro 'sk_v6_daddr'
       *pin6 = sk->sk_v6_daddr;
                   ^~~~~~~~~~~
   In file included from include/trace/define_trace.h:96:0,
                    from include/trace/events/tcp.h:68,
                    from net/core/net-traces.c:34:
   include/trace/events/tcp.h: In function 'perf_trace_tcp_retransmit_skb':
>> include/net/sock.h:348:36: error: 'struct sock_common' has no member named 
>> 'skc_v6_rcv_saddr'; did you mean 'skc_rcv_saddr'?
    #define sk_v6_rcv_saddr __sk_common.skc_v6_rcv_saddr
                                       ^
   include/trace/perf.h:65:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
     { assign; }       \
       ^~~~~~
   include/trace/trace_events.h:77:9: note: in expansion of macro 'PARAMS'
            PARAMS(assign),         \
            ^~~~~~
   include/trace/events/tcp.h:12:1: note: in expansion of macro 'TRACE_EVENT'
    TRACE_EVENT(tcp_retransmit_skb,
    ^~~~~~~~~~~
   include/trace/events/tcp.h:29:2: note: in expansion of macro 'TP_fast_assign'
     TP_fast_assign(
     ^~~~~~~~~~~~~~
   include/trace/events/tcp.h:49:16: note: in expansion of macro 
'sk_v6_rcv_saddr'
       *pin6 = sk->sk_v6_rcv_saddr;
                   ^~~~~~~~~~~~~~~
>> include/net/sock.h:347:33: error: 'struct sock_common' has no member named 
>> 'skc_v6_daddr'; did you mean 'skc_daddr'?
    #define sk_v6_daddr  __sk_common.skc_v6_daddr
                                    ^
   include/trace/perf.h:65:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
     { assign; }       \
       ^~~~~~
   include/trace/trace_events.h:77:9: note: in expansion of macro 'PARAMS'
            PARAMS(assign),         \
            ^~~~~~
   include/trace/events/tcp.h:12:1: note: in expansion of macro 'TRACE_EVENT'
    TRACE_EVENT(tcp_retransmit_skb,
    ^~~~~~~~~~~
   include/trace/events/tcp.h:29:2: note: in expansion of macro 'TP_fast_assign'
     TP_fast_assign(
     ^~~~~~~~~~~~~~
   include/trace/events/tcp.h:51:16: note: in expansion of macro 'sk_v6_daddr'
       *pin6 = sk->sk_v6_daddr;
                   ^~~~~~~~~~~

vim +348 include/net/sock.h

4dc6dc716 Eric Dumazet             2009-07-15  327  
68835aba4 Eric Dumazet             2010-11-30  328  #define sk_dontcopy_begin   
__sk_common.skc_dontcopy_begin
68835aba4 Eric Dumazet             2010-11-30  329  #define sk_dontcopy_end     
        __sk_common.skc_dontcopy_end
4dc6dc716 Eric Dumazet             2009-07-15  330  #define sk_hash             
        __sk_common.skc_hash
508054668 Eric Dumazet             2013-10-02  331  #define sk_portpair         
__sk_common.skc_portpair
05dbc7b59 Eric Dumazet             2013-10-03  332  #define sk_num              
        __sk_common.skc_num
05dbc7b59 Eric Dumazet             2013-10-03  333  #define sk_dport            
__sk_common.skc_dport
508054668 Eric Dumazet             2013-10-02  334  #define sk_addrpair         
__sk_common.skc_addrpair
508054668 Eric Dumazet             2013-10-02  335  #define sk_daddr            
__sk_common.skc_daddr
508054668 Eric Dumazet             2013-10-02  336  #define sk_rcv_saddr        
        __sk_common.skc_rcv_saddr
^1da177e4 Linus Torvalds           2005-04-16  337  #define sk_family           
__sk_common.skc_family
^1da177e4 Linus Torvalds           2005-04-16  338  #define sk_state            
__sk_common.skc_state
^1da177e4 Linus Torvalds           2005-04-16  339  #define sk_reuse            
__sk_common.skc_reuse
055dc21a1 Tom Herbert              2013-01-22  340  #define sk_reuseport        
        __sk_common.skc_reuseport
9fe516ba3 Eric Dumazet             2014-06-27  341  #define sk_ipv6only         
__sk_common.skc_ipv6only
26abe1437 Eric W. Biederman        2015-05-08  342  #define sk_net_refcnt       
        __sk_common.skc_net_refcnt
^1da177e4 Linus Torvalds           2005-04-16  343  #define sk_bound_dev_if     
        __sk_common.skc_bound_dev_if
^1da177e4 Linus Torvalds           2005-04-16  344  #define sk_bind_node        
        __sk_common.skc_bind_node
8feaf0c0a Arnaldo Carvalho de Melo 2005-08-09  345  #define sk_prot             
        __sk_common.skc_prot
07feaebfc Eric W. Biederman        2007-09-12  346  #define sk_net              
        __sk_common.skc_net
efe4208f4 Eric Dumazet             2013-10-03 @347  #define sk_v6_daddr         
__sk_common.skc_v6_daddr
efe4208f4 Eric Dumazet             2013-10-03 @348  #define sk_v6_rcv_saddr     
__sk_common.skc_v6_rcv_saddr
33cf7c90f Eric Dumazet             2015-03-11  349  #define sk_cookie           
__sk_common.skc_cookie
70da268b5 Eric Dumazet             2015-10-08  350  #define sk_incoming_cpu     
        __sk_common.skc_incoming_cpu
8e5eb54d3 Eric Dumazet             2015-10-08  351  #define sk_flags            
__sk_common.skc_flags
ed53d0ab7 Eric Dumazet             2015-10-08  352  #define sk_rxhash           
__sk_common.skc_rxhash
efe4208f4 Eric Dumazet             2013-10-03  353  
^1da177e4 Linus Torvalds           2005-04-16  354      socket_lock_t           
sk_lock;
9115e8cd2 Eric Dumazet             2016-12-03  355      atomic_t                
sk_drops;
9115e8cd2 Eric Dumazet             2016-12-03  356      int                     
sk_rcvlowat;
9115e8cd2 Eric Dumazet             2016-12-03  357      struct sk_buff_head     
sk_error_queue;
b178bb3df Eric Dumazet             2010-11-16  358      struct sk_buff_head     
sk_receive_queue;
fa438ccfd Eric Dumazet             2007-03-04  359      /*
fa438ccfd Eric Dumazet             2007-03-04  360       * The backlog queue is 
special, it is always used with
fa438ccfd Eric Dumazet             2007-03-04  361       * the per-socket 
spinlock held and requires low latency
fa438ccfd Eric Dumazet             2007-03-04  362       * access. Therefore we 
special case it's implementation.
b178bb3df Eric Dumazet             2010-11-16  363       * Note : rmem_alloc is 
in this structure to fill a hole
b178bb3df Eric Dumazet             2010-11-16  364       * on 64bit arches, not 
because its logically part of
b178bb3df Eric Dumazet             2010-11-16  365       * backlog.
fa438ccfd Eric Dumazet             2007-03-04  366       */
fa438ccfd Eric Dumazet             2007-03-04  367      struct {
b178bb3df Eric Dumazet             2010-11-16  368              atomic_t        
rmem_alloc;
b178bb3df Eric Dumazet             2010-11-16  369              int             
len;
fa438ccfd Eric Dumazet             2007-03-04  370              struct sk_buff  
*head;
fa438ccfd Eric Dumazet             2007-03-04  371              struct sk_buff  
*tail;
fa438ccfd Eric Dumazet             2007-03-04  372      } sk_backlog;
b178bb3df Eric Dumazet             2010-11-16  373  #define sk_rmem_alloc 
sk_backlog.rmem_alloc
2c8c56e15 Eric Dumazet             2014-11-11  374  
9115e8cd2 Eric Dumazet             2016-12-03  375      int                     
sk_forward_alloc;
e0d1095ae Cong Wang                2013-08-01  376  #ifdef 
CONFIG_NET_RX_BUSY_POLL
dafcc4380 Eliezer Tamir            2013-06-14  377      unsigned int            
sk_ll_usec;
9115e8cd2 Eric Dumazet             2016-12-03  378      /* ===== mostly read 
cache line ===== */
9115e8cd2 Eric Dumazet             2016-12-03  379      unsigned int            
sk_napi_id;
060212928 Eliezer Tamir            2013-06-10  380  #endif
b178bb3df Eric Dumazet             2010-11-16  381      int                     
sk_rcvbuf;
b178bb3df Eric Dumazet             2010-11-16  382  
b178bb3df Eric Dumazet             2010-11-16  383      struct sk_filter __rcu  
*sk_filter;
ceb5d58b2 Eric Dumazet             2015-11-29  384      union {
eaefd1105 Eric Dumazet             2011-02-18  385              struct 
socket_wq __rcu  *sk_wq;
ceb5d58b2 Eric Dumazet             2015-11-29  386              struct 
socket_wq        *sk_wq_raw;
ceb5d58b2 Eric Dumazet             2015-11-29  387      };
def8b4faf Alexey Dobriyan          2008-10-28  388  #ifdef CONFIG_XFRM
d188ba86d Eric Dumazet             2015-12-08  389      struct xfrm_policy 
__rcu *sk_policy[2];
def8b4faf Alexey Dobriyan          2008-10-28  390  #endif
deaa58542 Eric Dumazet             2012-06-24  391      struct dst_entry        
*sk_rx_dst;
0e36cbb34 Cong Wang                2013-01-22  392      struct dst_entry __rcu  
*sk_dst_cache;
^1da177e4 Linus Torvalds           2005-04-16  393      atomic_t                
sk_omem_alloc;
4e07a91c3 Arnaldo Carvalho de Melo 2007-05-29  394      int                     
sk_sndbuf;
9115e8cd2 Eric Dumazet             2016-12-03  395  
9115e8cd2 Eric Dumazet             2016-12-03  396      /* ===== cache line for 
TX ===== */
9115e8cd2 Eric Dumazet             2016-12-03  397      int                     
sk_wmem_queued;
14afee4b6 Reshetova, Elena         2017-06-30  398      refcount_t              
sk_wmem_alloc;
9115e8cd2 Eric Dumazet             2016-12-03  399      unsigned long           
sk_tsq_flags;
75c119afe Eric Dumazet             2017-10-05  400      union {
9115e8cd2 Eric Dumazet             2016-12-03  401              struct sk_buff  
*sk_send_head;
75c119afe Eric Dumazet             2017-10-05  402              struct rb_root  
tcp_rtx_queue;
75c119afe Eric Dumazet             2017-10-05  403      };
^1da177e4 Linus Torvalds           2005-04-16  404      struct sk_buff_head     
sk_write_queue;
9115e8cd2 Eric Dumazet             2016-12-03  405      __s32                   
sk_peek_off;
9115e8cd2 Eric Dumazet             2016-12-03  406      int                     
sk_write_pending;
9b8805a32 Julian Anastasov         2017-02-06  407      __u32                   
sk_dst_pending_confirm;
218af599f Eric Dumazet             2017-05-16  408      u32                     
sk_pacing_status; /* see enum sk_pacing */
9115e8cd2 Eric Dumazet             2016-12-03  409      long                    
sk_sndtimeo;
9115e8cd2 Eric Dumazet             2016-12-03  410      struct timer_list       
sk_timer;
9115e8cd2 Eric Dumazet             2016-12-03  411      __u32                   
sk_priority;
9115e8cd2 Eric Dumazet             2016-12-03  412      __u32                   
sk_mark;
9115e8cd2 Eric Dumazet             2016-12-03  413      u32                     
sk_pacing_rate; /* bytes per second */
9115e8cd2 Eric Dumazet             2016-12-03  414      u32                     
sk_max_pacing_rate;
9115e8cd2 Eric Dumazet             2016-12-03  415      struct page_frag        
sk_frag;
9115e8cd2 Eric Dumazet             2016-12-03  416      netdev_features_t       
sk_route_caps;
9115e8cd2 Eric Dumazet             2016-12-03  417      netdev_features_t       
sk_route_nocaps;
9115e8cd2 Eric Dumazet             2016-12-03  418      int                     
sk_gso_type;
9115e8cd2 Eric Dumazet             2016-12-03  419      unsigned int            
sk_gso_max_size;
9115e8cd2 Eric Dumazet             2016-12-03  420      gfp_t                   
sk_allocation;
9115e8cd2 Eric Dumazet             2016-12-03  421      __u32                   
sk_txhash;
fc64869c4 Andrey Ryabinin          2016-05-18  422  
fc64869c4 Andrey Ryabinin          2016-05-18  423      /*
fc64869c4 Andrey Ryabinin          2016-05-18  424       * Because of non 
atomicity rules, all
fc64869c4 Andrey Ryabinin          2016-05-18  425       * changes are 
protected by socket lock.
fc64869c4 Andrey Ryabinin          2016-05-18  426       */
aa4c1037a David Ahern              2016-12-01  427      unsigned int            
__sk_flags_offset[0];
aa4c1037a David Ahern              2016-12-01  428  #ifdef __BIG_ENDIAN_BITFIELD
aa4c1037a David Ahern              2016-12-01  429  #define SK_FL_PROTO_SHIFT  
16
aa4c1037a David Ahern              2016-12-01  430  #define SK_FL_PROTO_MASK   
0x00ff0000
aa4c1037a David Ahern              2016-12-01  431  

:::::: The code at line 348 was first introduced by commit
:::::: efe4208f47f907b86f528788da711e8ab9dea44d ipv6: make lookups simpler and 
faster

:::::: TO: Eric Dumazet <eduma...@google.com>
:::::: CC: David S. Miller <da...@davemloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to