> -----Original Message----- > From: Eric Dumazet [mailto:eduma...@google.com] > Sent: Tuesday, October 17, 2017 4:21 AM > To: Henrik Austad <hen...@austad.us> > Cc: netdev <netdev@vger.kernel.org>; David S . Miller > <da...@davemloft.net>; Daniel Borkmann <dan...@iogearbox.net>; David > Ahern <dsah...@gmail.com>; Duyck, Alexander H > <alexander.h.du...@intel.com>; Willem de Bruijn <will...@google.com>; > John Fastabend <john.fastab...@gmail.com>; tcharding <m...@tobin.cc>; LKML > <linux-ker...@vger.kernel.org>; Henrik Austad <haus...@cisco.com>; Sanchez- > Palencia, Jesus <jesus.sanchez-palen...@intel.com> > Subject: Re: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to > compile as module > > On Tue, Oct 17, 2017 at 3:10 AM, Henrik Austad <hen...@austad.us> wrote: > > In commit 32302902ff09 ("mqprio: Reserve last 32 classid values for HW > > traffic classes and misc IDs") sch_mqprio started using > > netdev_txq_to_tc to find the correct tc instead of dev->tc_to_txq[] > > > > However, when mqprio is compiled as a module, it cannot resolve the > > symbol, leading to this error: > > > > ERROR: "netdev_txq_to_tc" [net/sched/sch_mqprio.ko] undefined! > > > > This adds an EXPORT_SYMBOL() since the other user in the kernel > > (netif_set_xps_queue) is also EXPORT_SYMBOL() (and not _GPL) or in a > > sysfs-callback. > > > > Cc: Alexander Duyck <alexander.h.du...@intel.com> > > Cc: Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com> > > Cc: David S. Miller <da...@davemloft.net> > > Signed-off-by: Henrik Austad <haus...@cisco.com> > > > Reviewed-by: Eric Dumazet <eduma...@google.com>
This is identical to a patch I submitted yesterday when I got the report from the kbuild robot. I would say your description looks much better than mine though so I would be good with dropping my patch in favor of this one. Acked-by: Alexander Duyck <alexander.h.du...@intel.com>
