Junote Cai reported that he was not able to get a DSA setup involving the DPAA/FMAN driver to work and narrowed it down to of_find_net_device_by_node() call in DSA setup. The initial attempt to fix this by adding of_node to the platform device results in a second, failed, probing of the FMan MAC driver against the new platform device created for the DPAA Ethernet driver. Solve these issues by removing the of_node pointer from the platform device and changing the net_dev dev to the of_device dev to ensure the DSA init will be able to find the DPAA net_dev using of_find_net_device_by_node(). Several changes were required to enable this solution: refactoring the adjust_link (also resulted in lesser, cleaner code) and renaming the fman kernel modules to keep the legacy udev rules happy.
Changes in v2: - fix issue on error path in "dpaa_eth: change device used" patch - cleanup the dpaa_eth_probe() error paths Changes in v3: - remove obsolete comment in moved code - add explanation for module rename Madalin Bucur (6): fsl/fman: remove of_node dpaa_eth: move of_phy_connect() to the eth driver dpaa_eth: change device used dpaa_eth: cleanup dpaa_eth_probe() error paths fsl/fman: add dpaa in module names dpaa_eth: remove obsolete comment drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 139 +++++++++++++------------ drivers/net/ethernet/freescale/fman/Makefile | 12 +-- drivers/net/ethernet/freescale/fman/mac.c | 135 +++++++----------------- drivers/net/ethernet/freescale/fman/mac.h | 6 +- 4 files changed, 115 insertions(+), 177 deletions(-) -- 2.1.0
