Re: [PATCH net-next] dsa: slave: support phy devices on external MII bus

[Martin Hundebøll]

Hi Andrew,

On 2017-10-16 14:40, Andrew Lunn wrote:

       /* internal MII */
       mdio {
         switch0phy1@1 {
           reg = <1>;
         };
       };

       /* external MII */
       mdio1 {
         switch0phy0: switch0phy0@0 {
           reg = <0>;
         };

Hi Martin

You are missing a compatible string here. The binding document says:

- mdio?         : Container of PHYs and devices on the external MDIO
                           bus. The node must contains a compatible string of
                           "marvell,mv88e6xxx-mdio-external"

          Andrew

Or am I missing something ?

// Martin

Yeah, I have it in my full dts file (attached snippet), but decided to limit the commit-message version to keep it short(er). Should I update the commit message to avoid confusing others? The issue is really that dsa_slave_phy_connect() always uses the the mdio bus associated with struct dsa_switch, even when the phy-handle refers to a phy from another mdio bus.

armada-388-gp.dts
Description: audio/vnd.dts